[#MMB-1724] make the 'verify' call in the DatabaseStorageManager optional - MMBase

Details

Type: New Feature
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.4, 1.5, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7.0, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6
Fix Version/s: 1.8.7
Component/s: Database Layer

Description:

It would be very useful to make the call to 'verify' optional to reduce startup times for automatic tests and development.

Environment:

any

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Peter Maas added a comment - 2008-09-24 17:01

This method is located in: org.mmbase.storage.implementation.database.DatabaseStorageManager

Show

Peter Maas added a comment - 2008-09-24 17:01 This method is located in: org.mmbase.storage.implementation.database.DatabaseStorageManager

Hide

Permalink

Michiel Meeuwissen added a comment - 2008-10-01 22:56

Use a property 'verifyTables' on mmbaseroot.xml (set it to false).

This can also be done in the context xml:

<Environment name="mmbase/mmbaseroot/verifyTables" value="false" type="java.lang.String" />

Show

Michiel Meeuwissen added a comment - 2008-10-01 22:56 Use a property 'verifyTables' on mmbaseroot.xml (set it to false). This can also be done in the context xml: <Environment name="mmbase/mmbaseroot/verifyTables" value="false" type="java.lang.String" />

Hide

Permalink

Michiel Meeuwissen added a comment - 2008-10-01 23:12

Actually, I was thinking, perhaps it is better to rename the property to something more generic like 'startupChecks'. It can then be consulted also when performing other kind of checks which are done during startup. E.g. the check for sanity and supported formats of image magick. If you're pretty sure that everything is ok, that 'd also be somethign that you may want do skip.

Show

Michiel Meeuwissen added a comment - 2008-10-01 23:12 Actually, I was thinking, perhaps it is better to rename the property to something more generic like 'startupChecks'. It can then be consulted also when performing other kind of checks which are done during startup. E.g. the check for sanity and supported formats of image magick. If you're pretty sure that everything is ok, that 'd also be somethign that you may want do skip.

Hide

Permalink

Michiel Meeuwissen added a comment - 2008-10-01 23:14

A message is now logged on INFO when it is to not 'verify' the tables. Perhaps it's even better to WARN about it, becuse I think mmbase may actually behave a bit differnently if the database tables do _not_ correspond to the builder xmls (the datatypes are in the verify method sometimes 'repared' to match the actual db-type).

Show

Michiel Meeuwissen added a comment - 2008-10-01 23:14 A message is now logged on INFO when it is to not 'verify' the tables. Perhaps it's even better to WARN about it, becuse I think mmbase may actually behave a bit differnently if the database tables do _not_ correspond to the builder xmls (the datatypes are in the verify method sometimes 'repared' to match the actual db-type).

Hide

Permalink

Peter Maas added a comment - 2008-10-02 08:07

I concur. Although I'd add a verb to the name of the method: runStartupCecks. Logging warnings to WARN doesn't sound to bad either!

Show

Peter Maas added a comment - 2008-10-02 08:07 I concur. Although I'd add a verb to the name of the method: runStartupCecks. Logging warnings to WARN doesn't sound to bad either!

Hide

Permalink

Michiel Meeuwissen added a comment - 2008-10-03 11:46

Ok, Ik made both changes as well.

Show

Michiel Meeuwissen added a comment - 2008-10-03 11:46 Ok, Ik made both changes as well.

People

Assignee:

Michiel Meeuwissen

Reporter:

Peter Maas
Votes:

0

Watchers:

1

Dates

Created:

2008-09-24 16:59

Updated:

2010-12-14 10:38

Resolved:

2008-10-01 22:56

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified