MMBase

Patch to get MMBase 1.9.2 of 2009-11-04 compiling

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.1
  • Fix Version/s: 1.9.2
  • Component/s: None
  1. mmbase-1.9.2-2009-11-04-nr2.patch
    (0,9 kB)
    Jacobjob
    2009-11-13 18:03
  2. mmbase-1.9.2-2009-11-04.patch
    (11 kB)
    Jacobjob
    2009-11-13 17:13

Activity

Hide
Jacobjob added a comment - 2009-11-13 17:14
The patch also turns off the feature to store a changed builder to XML. This saves lots of memory. :-)
Show
Jacobjob added a comment - 2009-11-13 17:14 The patch also turns off the feature to store a changed builder to XML. This saves lots of memory. :-)
Hide
Michiel Meeuwissen added a comment - 2009-11-13 19:00
I doubt if this issue is very helpfull.

If it is established that storing the DataType XML cost too much memory, it should be an issue of itself.

And as far as I know every module does compile correctly at the moment. Btw. subsets of modules can also be build using profiles. (See applications/pom.xml). This was mainly added to speed up a full build a bit if you're not interested in everything

Anyway, since this issue is only for documentation, can it be 'closed' then?
Show
Michiel Meeuwissen added a comment - 2009-11-13 19:00 I doubt if this issue is very helpfull. If it is established that storing the DataType XML cost too much memory, it should be an issue of itself. And as far as I know every module does compile correctly at the moment. Btw. subsets of modules can also be build using profiles. (See applications/pom.xml). This was mainly added to speed up a full build a bit if you're not interested in everything Anyway, since this issue is only for documentation, can it be 'closed' then?
Hide
Jacobjob added a comment - 2009-11-14 11:57
Turning off the XML writing is just a minor change.

The most important change I'd like to document was to turn off the modules that stopped us from building MMBase 1.9. Now I can easily use these patches again, for future builds, as long as I can not simply run 'mvn install -o' on the vanilla sources.

I've deployed the 1.9.2-20091104 version to the mmbase.org/maven2 repo, so we can use that version in CMSc 1.7 now.
Show
Jacobjob added a comment - 2009-11-14 11:57 Turning off the XML writing is just a minor change. The most important change I'd like to document was to turn off the modules that stopped us from building MMBase 1.9. Now I can easily use these patches again, for future builds, as long as I can not simply run 'mvn install -o' on the vanilla sources. I've deployed the 1.9.2-20091104 version to the mmbase.org/maven2 repo, so we can use that version in CMSc 1.7 now.
Hide
Jacobjob added a comment - 2009-11-16 09:38
Done and version is available using: 1.9.2-20091104
Show
Jacobjob added a comment - 2009-11-16 09:38 Done and version is available using: 1.9.2-20091104
Hide
Michiel Meeuwissen added a comment - 2009-11-16 15:01
So, for the actual release, the evidently existing problem (I don't quite understand it yet, because afaik everyting is building) is not yet solved?
Show
Michiel Meeuwissen added a comment - 2009-11-16 15:01 So, for the actual release, the evidently existing problem (I don't quite understand it yet, because afaik everyting is building) is not yet solved?
Hide
André van Toly added a comment - 2009-11-16 15:18
If I understand this correctly Jacojob you created a specific tag in svn for MMBase by patching (and disabling?) some code and by disabling the maven builds from several applications? Why didn't you patch what did not work? And/or create your own Maven project that did not include the builds you did not want?

And can you please specify what went wrong in your Maven build? To my knowledge everything builds fine.
Show
André van Toly added a comment - 2009-11-16 15:18 If I understand this correctly Jacojob you created a specific tag in svn for MMBase by patching (and disabling?) some code and by disabling the maven builds from several applications? Why didn't you patch what did not work? And/or create your own Maven project that did not include the builds you did not want? And can you please specify what went wrong in your Maven build? To my knowledge everything builds fine.
Hide
Jacobjob added a comment - 2009-11-16 16:57
To Michiel: yes, I can not get it building correctly, without disabling stuff (using the 4 november's code)

To Andre: I don't fully understand the broken things, so that's why I turned them off (mostly tests). Your suggestion is okay, but for now, I've a deadline.
In the future, I'll add a stacktrace.
Show
Jacobjob added a comment - 2009-11-16 16:57 To Michiel: yes, I can not get it building correctly, without disabling stuff (using the 4 november's code) To Andre: I don't fully understand the broken things, so that's why I turned them off (mostly tests). Your suggestion is okay, but for now, I've a deadline. In the future, I'll add a stacktrace.
Hide
André van Toly added a comment - 2009-11-16 17:14
Ah, I understand. In that case this issue can be closed.
Show
André van Toly added a comment - 2009-11-16 17:14 Ah, I understand. In that case this issue can be closed.

People

Dates

  • Created:
    2009-11-13 17:12
    Updated:
    2009-11-16 17:14
    Resolved:
    2009-11-16 09:38